Fix unnecessarily setting gluster volume option repeatedly #196
Conversation
runejuhl
force-pushed
the
fix-correcting-option
branch
from
9ac3889 to
f98ee4e
Compare
|
Thanks for the PR @runejuhl. Can you please add some tests for the datatypes? |
|
You're welcome @bastelfreak -- I've pushed some improvements. I'll be in front of a gluster cluster on Monday, I'll test it then and add some tests for the datatypes. |
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
runejuhl
force-pushed
the
fix-correcting-option
branch
2 times, most recently
from
145b6f1 to
9318a5f
Compare
|
Fixed the merge conflict, still need to add tests as requested in #196 (comment) |
|
Dear @runejuhl, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
runejuhl
force-pushed
the
fix-correcting-option
branch
from
9318a5f to
e14b155
Compare
Checks Gluster volume options against existing values to avoid repeatedly setting values Also adds these types: + `Gluster::VolumeName` + `Gluster::VolumeOption` And these functions: + `gluster::cmd_volume_get_option` + `gluster::onoff`
runejuhl
force-pushed
the
fix-correcting-option
branch
from
e14b155 to
e0fea8e
Compare
|
Dear @runejuhl, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Checks Gluster volume options against existing values to avoid repeatedly
setting values.
Also adds these types:
Gluster::VolumeNameGluster::VolumeOptionAnd these functions:
gluster::cmd_volume_get_optiongluster::onoff