Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The version parameter is deceptive #94

Open
smortex opened this issue Jul 12, 2023 · 3 comments · May be fixed by #97
Open

The version parameter is deceptive #94

smortex opened this issue Jul 12, 2023 · 3 comments · May be fixed by #97
Labels
needs-help Extra attention is needed

Comments

@smortex
Copy link
Member

smortex commented Jul 12, 2023

The version parameter default to "2.0.0" but is really only used when install_method is changed to "github": in the default configuration the module download and install the latest release of caddy regardless of the value of the version parameter.

Proposal:

  • Remove the default version of the parameter and make it optional;
  • Report an error when install_method is set to "github" but version is undef.
@smortex smortex added the needs-help Extra attention is needed label Jul 12, 2023
@smortex
Copy link
Member Author

smortex commented Jul 13, 2023

@AstraLuma @dhoppe maybe?

@AstraLuma
Copy link
Contributor

sounds good, as long as it's documented obviously and has reasonable defaults

@smortex
Copy link
Member Author

smortex commented Jul 18, 2023

My feeling is that 2.0.0 is old and making it mandatory for the user to set the version they want is better. I'll open a PR.

@smortex smortex linked a pull request Jul 18, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-help Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants