-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to install caddy from repos #114
base: master
Are you sure you want to change the base?
Conversation
Idempotency test fails with v6.1.2 and higher
# | ||
class caddy ( | ||
String[1] $version = '2.0.0', | ||
Optional[Enum['github']] $install_method = undef, | ||
Optional[Enum['github','repo']] $install_method = undef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should remove the 'Optional' part and add something like 'upstream'. Some people use Hiera to change settings in modules, and the current way make it impossible to revert to upstream on one host if another level in the hierarchy set it to something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I have that in my mind, but it'll be breaking change (potentially, if someone do class { 'caddy': install_method => undef }
). So far I'm trying to keep backward compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I'll change this, just in different PR.
Closes #62