Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve simplecov setup #278

Open
rnelson0 opened this issue Dec 2, 2016 · 2 comments
Open

Further improve simplecov setup #278

rnelson0 opened this issue Dec 2, 2016 · 2 comments

Comments

@rnelson0
Copy link
Member

rnelson0 commented Dec 2, 2016

@alexjfisher I was provided this gist by @jairojunior who has been using it with simplecov. https://gist.github.com/jairojunior/b1ff5ae7cb3f989fc3dca273dbbfe888

"Just be careful with functions (lib/puppet/parser) tested with rspec-puppet, no coverage report is produced for them in Puppet 4, and erroneous reports with Puppet 3."

What do you think, would this be an improvement to our setup if the issues can be remediated? I'm not too wise in the ways of simplecov but definitely want to get it working right.

@jairojunior
Copy link

Same travis job with different puppet versions:

Puppet 3.8.7: https://coveralls.io/jobs/20651738/source_files/2100350401

Puppet 4.2.3: https://coveralls.io/jobs/20651727/source_files/2100347598

Spec: https://github.com/biemond/biemond-wildfly/blob/master/spec/functions/service_config_spec.rb

Might be related to how rspec-puppet matcher (run.with_params) exercises the function under test.

I've been exploring simplecov and rspec-puppet code for a week or two now in order to have better coverage reports for Puppet projects, but still couldn't dedicate enough time to actually solve something.

As soon as I release wildfly 1.0.0 I'll investigate this. 😄

@ekohl
Copy link
Member

ekohl commented Nov 27, 2020

Is this still relevant or shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants