Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container health-check fails after creating a certificate #130

Closed
AFAde opened this issue Oct 8, 2024 · 4 comments · Fixed by #131
Closed

Container health-check fails after creating a certificate #130

AFAde opened this issue Oct 8, 2024 · 4 comments · Fixed by #131
Assignees

Comments

@AFAde
Copy link

AFAde commented Oct 8, 2024

Hi,
We ran the following command (within a running container) to generate a certificate for the Puppet board:

puppetserver ca generate --certname $CERTNAME

The issue is that the command saves the certificate to the ${SSLDIR}/certs folder, which causes the healthcheck.sh script to fail because the following line of code

certname=$(cd "${SSLDIR}/certs" && ls *.pem | grep --invert-match ca.pem)

cannot set the certname variable correctly.

The only way to fix the problem was to remove the newly generated .pem certificate from the directory (which is fine anyway, as it seems that the certificate is also copied to the ca/signed directory).

Could you please take a look at that? Is that a bug in the healthcheck.sh script? Or could it be that we have a wrong setting in the puppet.conf file?

Thanks

@rwaffen
Copy link
Member

rwaffen commented Oct 9, 2024

Thanks for the issue. I‘m not happy myself with this code. Was wondering when it will break. I have several local test to enhance this. But didn’t feel ready yet.

@rwaffen rwaffen self-assigned this Oct 9, 2024
@AFAde
Copy link
Author

AFAde commented Oct 9, 2024

Hi, thanks for the quick reply.

Well, I guess we have indeed broken it. Do you plan to fix it in a future release?

@rwaffen
Copy link
Member

rwaffen commented Oct 9, 2024

i'm right on it. have some time traveling. PR incomming!

@AFAde
Copy link
Author

AFAde commented Oct 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants