Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Weights and Improve Time Complexity of Prediction Methods #138

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

vivekjoshy
Copy link
Owner

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added test(s) covering the changes (if testable)

Lot of changes:

  • Implements per-player weights and/or partial play support.
  • Support a new balance flag to skew tail end skill ratings in high uncertainty matches. Complements beta parameter.
  • Add descriptions to README
  • Update dependencies
  • Reduce time complexity of all predict methods to $O(n^2)$.

Issue(s) Resolved

Fixes #29

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under openskill.py's MIT license.

I certify the above statement is true and correct: @vivekjoshy

Copy link

codecov bot commented Jul 15, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@vivekjoshy vivekjoshy merged commit 9d49c29 into main Jul 15, 2024
50 of 51 checks passed
@vivekjoshy vivekjoshy deleted the weights branch July 15, 2024 17:41
@philihp
Copy link
Contributor

philihp commented Jul 31, 2024

oh snap!! weights!? 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for partial play/weighting/player performance
2 participants