-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FizzBuzz Contribution #169
Open
LuceroLuciano
wants to merge
15
commits into
visualpartnership:master
Choose a base branch
from
LuceroLuciano:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contribución Open Source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribución Open Source
El siguiente código es un ejemplo de como se puede contribuir al código abierto.
Como primer punto se realizo un fork al respositorio, esto crea una copia del código en nuestro repo.
Abrir el repositorio, leer y entender las instrucciones. En este caso se requiere crear un nuevo endpoint que muestre la lista de explorers filtrados por stacks.
Solución
El proceso que se llevo a cabo para crear el nuevo endpoint es el siguiente:
getListExplorersByStack
que recibirá dos parámetros y filtrara la lista de explores utilizando el metodofilter
einclude
para que se muestre los valores del stack. Este método se creara en el archivoExplorerService.js
ExplorerService.test.js
para verificar que funciona correctamente.npm test test/services/ExplorerService.test.js
En este paso ya deberías tener instalado
jest
getListExplorersByStack
deExplorerService.js
Finalmente se crea el nuevo endpoint en el archivo
server.js
Ejecutar ESLInt como guía de diseño para corregir los errores de identación, comillas, punto y coma, entre otros.
npm run linter
para ver los erroresnpm linter --fix
para corregir los errorespackage-lock.json
.gitignore
y agregar el**/pakcage-lock.json
dentro del archivo .gitignoregit rm --cache package-look.json
commit
ypush
Enpoint en funcionamiento
Lista de explorers filtrada por stacks
En el navegador:
Con Postman: