Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR Feedback implementation #24

Merged
merged 2 commits into from
Nov 20, 2024
Merged

PR Feedback implementation #24

merged 2 commits into from
Nov 20, 2024

Conversation

Ivor
Copy link
Contributor

@Ivor Ivor commented Oct 25, 2024 •
edited
Loading

Ivor
Ivor commented Oct 25, 2024
View reviewed changes
lib/meta_logger/slicer.ex Show resolved Hide resolved
lib/meta_logger/slicer/default_impl.ex Show resolved Hide resolved
lib/meta_logger/slicer/default_impl.ex Show resolved Hide resolved
lib/meta_logger/slicer/utf8_impl.ex Show resolved Hide resolved
lib/meta_logger/slicer/utf8_impl.ex Show resolved Hide resolved
test/meta_logger/slicer/default_impl_test.exs Show resolved Hide resolved
@Ivor Ivor marked this pull request as ready for review October 25, 2024 14:35
@Ivor Ivor requested a review from prodis October 25, 2024 14:35
prodis
prodis approved these changes Nov 19, 2024
View reviewed changes
lib/meta_logger/slicer/utf8_impl.ex Show resolved Hide resolved
test/meta_logger/slicer/utf8_impl_test.exs Show resolved Hide resolved
@Ivor Ivor force-pushed the sc-133709-implement-pr-feedback branch from ccf3a80 to 0d631d9 Compare November 20, 2024 15:08
@nvieirafelipe nvieirafelipe merged commit 11b51ee into master Nov 20, 2024
3 checks passed
@nvieirafelipe nvieirafelipe deleted the sc-133709-implement-pr-feedback branch November 20, 2024 15:12
@nvieirafelipe
Copy link
Collaborator

ℹ️ I'm not releasing a new version with those changes as they are only related to the style guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prodis prodis prodis approved these changes

Assignees

@Ivor Ivor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivor @nvieirafelipe @prodis