Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-9179: add ml training wrappers #4588

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

RSDK-9179: add ml training wrappers #4588

wants to merge 18 commits into from

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Nov 26, 2024 •
edited
Loading

Main change:

  • added ml training wrappers

Additional changes:

  • removed the proto conversion files and moved the types and functions to the appropriate client files
  • added checks for nil pointers in all app clients
  • moved all functions to the bottom of client files

@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 26, 2024
@purplenicole730 purplenicole730 marked this pull request as ready for review November 26, 2024 22:24
@purplenicole730 purplenicole730 requested review from a team, njooma and lia-viam and removed request for a team November 26, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma Awaiting requested review from njooma njooma was automatically assigned from viamrobotics/sdk-netcode

@lia-viam lia-viam Awaiting requested review from lia-viam lia-viam was automatically assigned from viamrobotics/sdk-netcode

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@purplenicole730 @viambot