RPS mode with cold/warm ratio #557

cvetkovic · 2024-11-15T10:21:13Z

Support for RPS mode
Reimplementation of individual trace driver
Specification generator bugfixing
Code stability improvement (a lot of new unit and integration tests)
Workload code deduplication
Knative deployment parallelization
Code moving and beautification

cvetkovic · 2024-11-15T17:32:32Z

@leokondrashov: This is the last PR from the big one. Please have a look thoroughly at this once, since it affects the core functionality of the loader. After this one, I will follow up with a new one that will extract Dirigent-specific features/settings.

leokondrashov

We should clarify the interpretation of the IAT array; only then can I check the driver and spec generation code. Right now, it seems inconsistent in the tests for RPS and trace modes.

pkg/trace/parser.go

pkg/workload/openwhisk/workload_openwhisk.go

pkg/driver/trace_driver.go

pkg/generator/rps_test.go

pkg/common/specification_types.go

pkg/generator/rps_test.go

pkg/generator/specification.go

pkg/generator/rps_test.go

pkg/driver/deployment/knative.go

Signed-off-by: Lazar Cvetković <[email protected]>

leokondrashov

I looked over test cases, I don't think they are right, the expected values don't make sense. I've proposed the solution, it should work as I outlined in the description.

pkg/generator/specification_test.go

pkg/generator/rps_test.go

pkg/generator/specification.go

Signed-off-by: Lazar Cvetković <[email protected]>

pkg/generator/specification_test.go

pkg/generator/specification.go

Signed-off-by: Lazar Cvetković <[email protected]>

pkg/generator/specification_test.go

Signed-off-by: Lazar Cvetković <[email protected]>

leokondrashov

Some minor issues in the tests for the generator; otherwise, looks good. But I have concerns about the driver now. Since we are not necessarily hit the minute border, we should be careful how it is handled (especially, startOfMinute, previousIATSum, and minuteIndex for empty minutes)

pkg/generator/specification_test.go

pkg/generator/rps_test.go

pkg/generator/rps.go

pkg/driver/trace_driver.go

docs/configuration.md

pkg/driver/trace_driver.go

Signed-off-by: Lazar Cvetković <[email protected]>

leokondrashov

Some minor fixes in specification tests again. There is a change in the driver that is inconsistent with the rest of the code: experiment duration with second granularity. In the front-end we interpret experiment duration as seconds, but in driver, now, we try to interpret it as number of minutes. See the comment for functionsDriver.

pkg/generator/specification_test.go

pkg/generator/rps_test.go

pkg/driver/trace_driver.go

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic force-pushed the rps_feature branch from 9c2dfe9 to cdb68d7 Compare November 15, 2024 15:26

cvetkovic requested a review from leokondrashov November 15, 2024 17:28

cvetkovic changed the title ~~RPS mode - new feature~~ RPS mode with cold/warm ratio Nov 15, 2024

leokondrashov reviewed Nov 21, 2024

View reviewed changes

leokondrashov reviewed Nov 22, 2024

View reviewed changes

pkg/driver/deployment/knative.go Outdated Show resolved Hide resolved

cvetkovic force-pushed the rps_feature branch from 2a8c9f1 to cb757da Compare November 25, 2024 18:42

cvetkovic added 13 commits November 25, 2024 21:19

RPS mode - new feature

32f9e1e

Signed-off-by: Lazar Cvetković <[email protected]>

YAML fixes

4033f8d

Signed-off-by: Lazar Cvetković <[email protected]>

Read/Write IAT and generate specs knobs

e831ffc

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing tests

968f069

Signed-off-by: Lazar Cvetković <[email protected]>

Porting minor changes from aux branch

64e3219

Signed-off-by: Lazar Cvetković <[email protected]>

Failure rate percentage logging

0eb270c

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing DAG test

a86ddf7

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing tests

757ebc5

Signed-off-by: Lazar Cvetković <[email protected]>

Extracting Dirigent metadata parsing from Azure parser

ee2367b

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing typo in trace driver

05198bc

Signed-off-by: Lazar Cvetković <[email protected]>

Extracting specification generator to a separate method

1ff197d

Signed-off-by: Lazar Cvetković <[email protected]>

Bugfix on Knative parallel deploy

f046e99

Signed-off-by: Lazar Cvetković <[email protected]>

Moving driver-unrelated code (metrics) to separate package

c0d3b02

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic force-pushed the rps_feature branch from 8558bb7 to c0d3b02 Compare November 25, 2024 20:19

cvetkovic added 8 commits November 25, 2024 21:32

Variable renaming and fixing hanging comment

4887435

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing IAT for empty time slot

6d29c10

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing runtime specification test

d6b0591

Signed-off-by: Lazar Cvetković <[email protected]>

Bugfix: some invocations got ommited if at the end of array

050d5ac

Signed-off-by: Lazar Cvetković <[email protected]>

RPS mode without RpsCooldownSeconds offset with fixed tests

07875f8

Signed-off-by: Lazar Cvetković <[email protected]>

Comment on IATArray purpose

805e057

Signed-off-by: Lazar Cvetković <[email protected]>

Extracting commons from OpenWhisk and our function

389e81f

Signed-off-by: Lazar Cvetković <[email protected]>

Shift IAT test and fix

f8f2f13

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic requested a review from leokondrashov November 26, 2024 10:28

leokondrashov reviewed Nov 26, 2024

View reviewed changes

cvetkovic added 2 commits November 26, 2024 15:59

Bugfixing IAT generation for empty minutes

dff61bc

Signed-off-by: Lazar Cvetković <[email protected]>

Fixing linter

279e28d

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic requested a review from leokondrashov November 26, 2024 15:05

More unit tests for low RPS and huge cooldown

c15a643

Signed-off-by: Lazar Cvetković <[email protected]>

leokondrashov reviewed Nov 27, 2024

View reviewed changes

pkg/generator/specification_test.go Outdated Show resolved Hide resolved

pkg/generator/specification.go Outdated Show resolved Hide resolved

pkg/generator/specification.go Outdated Show resolved Hide resolved

Bugfixing IAT generation issues - Leonid's solution

134b82c

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic requested a review from leokondrashov November 27, 2024 10:08

leokondrashov reviewed Nov 28, 2024

View reviewed changes

pkg/generator/specification_test.go Outdated Show resolved Hide resolved

Fixing testing checks

0843abe

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic requested a review from leokondrashov November 28, 2024 09:55

leokondrashov reviewed Nov 28, 2024

View reviewed changes

cvetkovic added 3 commits November 28, 2024 14:52

Another round of code improvements - Leonid's feedback

2c49b49

Signed-off-by: Lazar Cvetković <[email protected]>

Per-minute count check

090e6a6

Signed-off-by: Lazar Cvetković <[email protected]>

New individual function driver

20d1dc6

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic force-pushed the rps_feature branch from 29a5fe9 to 20d1dc6 Compare November 28, 2024 18:03

cvetkovic requested a review from leokondrashov November 28, 2024 18:06

leokondrashov reviewed Nov 29, 2024

View reviewed changes

Applying new round of Leonid's feedback

ce7250d

Signed-off-by: Lazar Cvetković <[email protected]>

cvetkovic force-pushed the rps_feature branch from 11a1952 to ce7250d Compare November 29, 2024 09:21

cvetkovic requested a review from leokondrashov November 29, 2024 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPS mode with cold/warm ratio #557

RPS mode with cold/warm ratio #557

cvetkovic commented Nov 15, 2024 •

edited

Loading

cvetkovic commented Nov 15, 2024

leokondrashov left a comment

leokondrashov left a comment

leokondrashov left a comment

leokondrashov left a comment

RPS mode with cold/warm ratio #557

Are you sure you want to change the base?

RPS mode with cold/warm ratio #557

Conversation

cvetkovic commented Nov 15, 2024 • edited Loading

cvetkovic commented Nov 15, 2024

leokondrashov left a comment

Choose a reason for hiding this comment

leokondrashov left a comment

Choose a reason for hiding this comment

leokondrashov left a comment

Choose a reason for hiding this comment

leokondrashov left a comment

Choose a reason for hiding this comment

cvetkovic commented Nov 15, 2024 •

edited

Loading