Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Filters #1115

Open
ritwik12 opened this issue Dec 14, 2018 · 13 comments
Open

Improve Filters #1115

ritwik12 opened this issue Dec 14, 2018 · 13 comments

Comments

@ritwik12
Copy link
Collaborator

ritwik12 commented Dec 14, 2018

Right now we are able to apply all the filters simultaneously. The only problem is that, Once we apply a filter say "Filter by tags - Python" and we again apply another filter say "Filter by name:" or "Filter by label:" then we should only be getting the names in the SELECT list to choose which are related to "python" or labels related to "python" only. But right now there is no effect on the SELECT after applying filter.

wolffles added a commit to wolffles/up-for-grabs.net that referenced this issue Jan 10, 2019
@wanderdust
Copy link

Hey! I've been using the website, and the filter "Filter by tags" doesn't seem to be working. It only works when you use the popular tags ones. If nobody is doing this I would like to work on it. Thanks!

@wolffles
Copy link
Contributor

@wanderdust I already submitted a pull request fixing it. right above your comment.

ritwik12 added a commit that referenced this issue Jan 11, 2019
@BhaskarJoshi-01
Copy link

i want to take this issue

@ritwik12
Copy link
Collaborator Author

ritwik12 commented Oct 9, 2019

Sure @LuciferJoshi, go on and let us know if you have some cool implementation to make things easier. Please do check what we already have

@jordar411
Copy link

@ritwik12 Would you be opposed if we contributed a tag counter on each filter? There are so many different tags, and some of them return zero results when applied. Could be an easy, yet effective value-add.

@jordar411
Copy link

@ritwik12 excuse me, I meant "labels" in my previous post.

@ritwik12
Copy link
Collaborator Author

ritwik12 commented Nov 6, 2020

@jordar411 Hey, I could not understand that clearly. But if you mean quantifying the LABELS then I think we already have it under Popular tags:. If it's something else then can you please elaborate with an example, please?

@jordar411
Copy link

jordar411 commented Nov 6, 2020

@jordar411 Hey, I could not understand that clearly. But if you mean quantifying the LABELS then I think we already have it under Popular tags:. If it's something else then can you please elaborate with an example, please?

@ritwik12
I'm sorry! I've attached screenshots for reference. imageimage

The total amount of items references by a specific label. If you feel that this is redundant, I can disregard. 😄

@ritwik12
Copy link
Collaborator Author

ritwik12 commented Nov 7, 2020

@jordar411 I got it now, thanks for the explanation. I think it will not be suitable to show them up in the field itself. We can introduce something same as "Popular tags:" like "Popular Labels:" and show the Highest count values like 5-6. What do you think? How would you like to show the counts instead?

@jordar411
Copy link

@ritwik12 I like that idea! I can 100% do that, with your approval.

@ritwik12
Copy link
Collaborator Author

ritwik12 commented Nov 7, 2020

@jordar411 Sure, go for it please.

@Aditya-Naresh
Copy link

Is this issue still open?

@Sanjaykumarshahu
Copy link

Bot code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants