Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChipGroup] default selection enforced by ChipSelectionMode=Single, no longer work due to ItemsPanelRoot's new resolution timing #1287

Open
Xiaoy312 opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
control/chip-chipgroup control/tabbar kind/bug Something isn't working kind/regression Something was working, now it isn't

Comments

@Xiaoy312
Copy link
Contributor

Xiaoy312 commented Nov 21, 2024

Current behavior

^ title

Expected behavior

Default selection should be enforced with ChipSelectionMode=Single.

How to reproduce it (as minimally and precisely as possible)

  • bump toolkit to an Uno.WinUI that contains the TemplatedParent rework (which impacted ItemsPanelRoot resolution timing)
  • launc the sample app
  • run this test: VariousMode_TapSelection
  • notices the ChipSelectionMode.Single set of tests fails

Package Version(s): [email protected]
Affected platform(s): all
IDE: don't matter
Relevant plugins: n/a

Anything else we need to know?

Somewhat related to #1281, but that one can be worked around by accessing the containers via ItemsControl::Items instead, since we have xaml-defined items, while here we are dealing with ItemsSource'd items...

@Xiaoy312 Xiaoy312 added kind/bug Something isn't working control/chip-chipgroup labels Nov 21, 2024
@Xiaoy312 Xiaoy312 self-assigned this Nov 21, 2024
@Xiaoy312 Xiaoy312 added kind/regression Something was working, now it isn't control/tabbar labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control/chip-chipgroup control/tabbar kind/bug Something isn't working kind/regression Something was working, now it isn't
Projects
None yet
Development

No branches or pull requests

1 participant