Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve arg help usage message (placeholder) #147

Open
1 task done
janniks opened this issue May 28, 2024 · 1 comment
Open
1 task done

Improve arg help usage message (placeholder) #147

janniks opened this issue May 28, 2024 · 1 comment

Comments

@janniks
Copy link

janniks commented May 28, 2024

Describe the feature

Right now the required arg Usage looks as follow in the screenshot: (taken from repo playground)

Running npx tsx ./playground/cli.ts build --hmr 5 --workDir HERE in the citty repo:

Screenshot 2024-05-28 at 16 22 19

This makes it seems like the [ENTRY] is where the work dir input should go.
The screenshot with the positional entry makes it even more confusing. The angle brackets are typically used to show the placeholder of the preceeding -- arg

From googling around it seems the more common way is to have the usage show (example):

Usage:
  my-cli --timeout <ms> [--optional <path>]


Usage:
  my-cli --timeout ms <entry>

Optionality denoted with square bracket, but still showing a placeholder where the actual input goes (assuming the arg is NOT a boolean and requires an input). It seems the type of the input is often given as the placeholder value (although this would require another field in the arg spec of citty).

I like the upcasing for positional required args. But it always looks a bit confusing after a flag. Just wanted to leave that comment here.

Additional information

  • Would you be willing to help implement this feature?
@zuixinwang
Copy link
Contributor

The positional arg should be placed before other args and should not exceed one
If there is more than one, only one positional arg should be retained, and the rest should be implemented using non-positional args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants