add javac plugin #22
add javac plugin #22
Conversation
|
|
| for(String arg : args) { | ||
| if(arg.contains("=")) { | ||
| String[] split = arg.split("=", 2); | ||
| switch(split[0]) { | ||
| case "api": | ||
| if(flags.api == null) { | ||
| flags.api = new ArrayList<>(); | ||
| } | ||
| for(String s : split[1].split(p)) { | ||
| flags.api.add(new File(s)); | ||
| } | ||
| break; | ||
| case "logLevel": | ||
| case "log": | ||
| flags.logLevel = Logger.Level.valueOf(split[1].toUpperCase(Locale.ROOT)); | ||
| break; | ||
| case "skipStubs": | ||
| for(String s : split[1].split(",")) { | ||
| flags.debugSkipStubs.add(Integer.parseInt(s)); | ||
| } | ||
| break; | ||
| case "target": | ||
| flags.classVersion = Utils.majorVersionToClassVersion(Integer.parseInt(split[1])); | ||
| break; | ||
| case "classpath": | ||
| case "cp": | ||
| for(String s : split[1].split(p)) { | ||
| try { | ||
| classpathURLs.add(new File(s).toURI().toURL()); | ||
| } catch (Throwable t1) { | ||
| Utils.sneakyThrow(t1); | ||
| } | ||
| } | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
does this have to have it's own seperate args. also the args should at least match the names of the ones in https://github.com/unimined/JvmDowngrader/blob/main/src/main/java/xyz/wagyourtail/jvmdg/cli/Main.java and maybe share some of the logic.
also, does it really make sense for the classpath for jvmdg to be different than the classpath provided to javac?
also, also, you can pass VM properties into javac somehow, which can also be used to set the jvmdg flags, so is this nececairy at all? https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#option-J
There was a problem hiding this comment.
I could make it delegate to Main, that would just require a little moving of logic in Main around so I can get the parsed Flags. I'm not a particularly big fan of using -J though, I think having the arguments as the arguments to the plugin would work better.
javac-plugin/build.gradle.kts
Outdated
| @@ -17,7 +17,8 @@ dependencies { | |||
| } | |||
|
|
|||
| tasks.compileTestJava { | |||
| classpath += rootProject.tasks["shadowJar"].outputs.files | |||
| classpath += project(":java-api").tasks.getByName("testJar").outputs.files + | |||
| files(rootProject.sourceSets.map { it.compileClasspath }.flatten()) | |||
There was a problem hiding this comment.
second part could be rootProject.tasks["jar"]outputs.files I think
There was a problem hiding this comment.
also I would've passed the api jar as a flag, instead of directly putting it on the classpath. like I do in the other testing subproject
There was a problem hiding this comment.
yeah the second one is a good idea
builds using java 8 since that's when javac plugins were introduced
I bundle it into the
-alljar for easy depending (annotationProcessor("xyz.wagyourtail...:all"))and all the test has to do is compile and run on java 8