CLDR-18155 Order languageData's scripts by number of users #4237
Conversation
conradarcturus
force-pushed
the
CLDR-18155-Order-languageData-scripts-by-usage
branch
from
757c108 to
cbce758
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
| @@ -1346,7 +1346,7 @@ XXX Code for transations where no currency is involved | |||
| <language type="awa" scripts="Deva"/> | |||
| <language type="awa" territories="IN" alt="secondary"/> | |||
| <language type="ay" scripts="Latn" territories="BO"/> | |||
| <language type="az" scripts="Arab Cyrl Latn" territories="AZ"/> | |||
| <language type="az" scripts="Arab Latn Cyrl" territories="AZ"/> | |||
There was a problem hiding this comment.
likely subtags for az is az_Latn_AZ but I will note there are more Azerbaijani speakers in Iran (az_Arab_IR). It's just that they haven't transitioned to the internet like Azerbaijan has.
| @@ -1918,7 +1918,7 @@ XXX Code for transations where no currency is involved | |||
| <language type="mai" scripts="Tirh" territories="IN NP" alt="secondary"/> | |||
| <language type="mak" scripts="Latn"/> | |||
| <language type="mak" scripts="Bugi" territories="ID" alt="secondary"/> | |||
| <language type="man" scripts="Latn Nkoo"/> | |||
| <language type="man" scripts="Nkoo Latn"/> | |||
There was a problem hiding this comment.
This is driven by the Ghana language entry saying there is a large Manding population using Nkoo in Ghana. Really man is a macrolanguage code so we shouldn't give that much weight to this entry being one writing or another. https://en.wikipedia.org/wiki/Manding_languages
There was a problem hiding this comment.
Can you check that again? Nkoo figures can be skewed by advocacy.
| @@ -2435,7 +2435,7 @@ XXX Code for transations where no currency is involved | |||
| <language type="yrk" scripts="Cyrl"/> | |||
| <language type="yrl" scripts="Latn"/> | |||
| <language type="yua" scripts="Latn"/> | |||
| <language type="yue" scripts="Hans Hant" territories="MO"/> | |||
| <language type="yue" scripts="Hant Hans" territories="MO"/> | |||
There was a problem hiding this comment.
yue's likely subtag is yue_Hant_HK
| public BasicLanguageData setScriptsWithoutPopulation(String scriptTokens) { | ||
| List<String> scripts = new ArrayList<>(); | ||
| if (scriptTokens != null) { | ||
| scripts = Arrays.asList(WHITESPACE_PATTERN.split(scriptTokens)); |
There was a problem hiding this comment.
Splitter ha a split to list, fyi
| for (String script : scripts) { | ||
| scriptsByPopulation.put(script, 0); | ||
| } | ||
| return setScripts(scriptsByPopulation); |
There was a problem hiding this comment.
Better to build once, make immutable.
CLDR-18155
This sorts the scripts in the SupplementalData tags such that the first script has the highest population. This helps resolve some of the ambiguities interpreting the data.
ALLOW_MANY_COMMITS=true