Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not completely fail downloads of resources due to missing files #7580

Open
PhotoNomad0 opened this issue Jul 11, 2024 · 3 comments
Open
Assignees
Labels

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jul 11, 2024

Summary

The current download of unfoldingword/en_twl fails because there are files mentioned in manfest projects that are missing in the repo. It seems that rather than failing the entire download, we should just process the files that are present in the repo and referenced in the manifest.

Motivation

According to Rich this is because they removed unpublished books from the repo, but not the manifest.

Specifications (If applicable)

A clear and concise description of the details about the feature that may or may not be obvious

Additional context

Add any other context or screenshots about the feature request here.

@PhotoNomad0 PhotoNomad0 self-assigned this Jul 11, 2024
@PhotoNomad0
Copy link
Contributor Author

@elsylambert Fix is in translationCore 3.6.5 (de28495)

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Jul 12, 2024

To test in tCore, download all the en resources from unfoldingWord - it should succeed.

@elsylambert
Copy link

Verified in translationCore 3.6.5 (de28495). Download of uW resource succeed without fail.
Screenshot 2024-07-12 at 10 34 42 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants