Critical: Content lost when upgrading from v13 to v15

[arknu]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.0

Bug summary

When upgrading a site from Umbraco 13.5 to 15.1, we are seeing content getting lost in the Block Grid Editor.
Specifically, labels for links in the MultiUrlPicker are lost. Also, internal links (both to content and media) are lost.

For instance, here is the link picker in v13:

Notice how the Link title field shows the page name as placeholder. This is rendered as content. In v15, it does not preserve this, thus leaving the field blank, leading to lost content. Here is the same link picker in v15. Notice the Link title is now blank:

Here is a link to a media item:

And the same link broken in v15:

HTML for the above:
v13:

<p><img src="/media/bbmmd5yl/pdf_file_grey.svg?rmode=max&amp;width=80&amp;height=80" alt="" width="80" height="80" data-udi="umb://media/ffc15839600b4527b7f35d072fd95e79"></p>
<p><a rel="noopener" href="/{localLink:umb://media/ea392ce4603d49839f0d338dcd072bb5}" target="_blank" title="En Henrettelse som pdf">En henrettelse</a></p>
<p><a rel="noopener" href="/{localLink:umb://media/2b6ecb5bd8fd4cb7b903915245879aee}" target="_blank" title="De tomme Pladsers Passagerer som pdf">De tomme pladsers passagerer</a></p>
<p><a rel="noopener" href="/{localLink:umb://media/ba7855bb0ba44e67b74680eb62076ee5}" target="_blank" title="Lotterisvensken som pdf">Lotterisvensken</a></p>

V15:

<p><img src="/media/bbmmd5yl/pdf_file_grey.svg?rmode=max&amp;width=80&amp;height=80" alt="" width="80" height="80" data-udi="umb://media/ffc15839600b4527b7f35d072fd95e79"></p>
<p><a rel="noopener" href="/umbraco/section/content/workspace/document/edit/997e86b7-cadb-43b3-b78e-441b7225e2ae/da/tab/indhold/modal/umb-modal-workspace/contentGrid/da/d997564F4432453A918E9Cf793666A3F/34ff0528-3727-4bd3-a5a3-888c7ed5ea67/block/edit/45dac8ee-ad96-4c02-b2d5-f6359bae7e7c/view/type=" target="_blank" title="En Henrettelse som pdf">En henrettelse</a></p>
<p><a rel="noopener" href="/umbraco/section/content/workspace/document/edit/997e86b7-cadb-43b3-b78e-441b7225e2ae/da/tab/indhold/modal/umb-modal-workspace/contentGrid/da/d997564F4432453A918E9Cf793666A3F/34ff0528-3727-4bd3-a5a3-888c7ed5ea67/block/edit/45dac8ee-ad96-4c02-b2d5-f6359bae7e7c/view/type=" target="_blank" title="De tomme Pladsers Passagerer som pdf">De tomme pladsers passagerer</a></p>
<p><a rel="noopener" href="/umbraco/section/content/workspace/document/edit/997e86b7-cadb-43b3-b78e-441b7225e2ae/da/tab/indhold/modal/umb-modal-workspace/contentGrid/da/d997564F4432453A918E9Cf793666A3F/34ff0528-3727-4bd3-a5a3-888c7ed5ea67/block/edit/45dac8ee-ad96-4c02-b2d5-f6359bae7e7c/view/type=" target="_blank" title="Lotterisvensken som pdf">Lotterisvensken</a></p>

And here I have manually corrected the first link:

<p><img src="/media/bbmmd5yl/pdf_file_grey.svg?rmode=max&amp;width=80&amp;height=80" alt="" width="80" height="80" data-udi="umb://media/ffc15839600b4527b7f35d072fd95e79"></p>
<p><a rel="noopener" type="media" href="/{localLink:ea392ce4-603d-4983-9f0d-338dcd072bb5}" target="_blank" title="En Henrettelse som pdf">En henrettelse</a></p>
<p><a rel="noopener" href="/umbraco/section/content/workspace/document/edit/997e86b7-cadb-43b3-b78e-441b7225e2ae/da/tab/indhold/modal/umb-modal-workspace/contentGrid/da/d997564F4432453A918E9Cf793666A3F/34ff0528-3727-4bd3-a5a3-888c7ed5ea67/block/edit/45dac8ee-ad96-4c02-b2d5-f6359bae7e7c/view/type=" target="_blank" title="De tomme Pladsers Passagerer som pdf">De tomme pladsers passagerer</a></p>
<p><a rel="noopener" href="/umbraco/section/content/workspace/document/edit/997e86b7-cadb-43b3-b78e-441b7225e2ae/da/tab/indhold/modal/umb-modal-workspace/contentGrid/da/d997564F4432453A918E9Cf793666A3F/34ff0528-3727-4bd3-a5a3-888c7ed5ea67/block/edit/45dac8ee-ad96-4c02-b2d5-f6359bae7e7c/view/type=" target="_blank" title="Lotterisvensken som pdf">Lotterisvensken</a></p>

The same thing happens for internal links to other content in the RTE.

It looks like the upgrade completely mangles internal links into something that doesn't make any sense.

Specifics

Upgrading from 13.5.1 to 15.1.0. Site is using TinyMCE.

Steps to reproduce

Upgrade a site using Block Grid Editor containing the above property editors from v13 to v15.

I can provide a database backup if needed.

Expected result / actual result

No content should ever be lost when upgrading, especially not from Core property editors

[github-actions]

Hi there @arknu!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[kjac]

Hi @arknu

Thank you for reporting this. We will look into it ASAP.