Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockLists and BlockGrids detects changes while there are none #17784

Closed
engern opened this issue Dec 11, 2024 · 2 comments
Closed

BlockLists and BlockGrids detects changes while there are none #17784

engern opened this issue Dec 11, 2024 · 2 comments

Comments

@engern
Copy link
Contributor

engern commented Dec 11, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.1.0

Bug summary

When navigating between nodes which has a BlockList or BlockGrid you get the "Discard Changes"-dialogue.

umbraco_discard_changes.mp4

Specifics

I did a JSON.stringify(x) on both _persisted and _current element in getHasUnpersistedChanges() (entity-workspace-data-manager.ts) and see that the _persisted is missing the entire BlockGrid in the values-array. So I guess this must be why it always detect that the current node is different from the persisted.
image

Steps to reproduce

  1. Create a DocumentType with a BlockList
  2. Create a content node/page with the document type in step 1
  3. Open the conent node created in step 2 (the tab with the BlockList must be selected)
  4. Navigate to another content node without doing any changes
  5. The "Discard Changes"-dialogue appears

Expected result / actual result

No "Discard Changes"-dialogue when navigating away from a node without doing any changes

Copy link

Hi there @engern!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan
Copy link
Member

Zeegaan commented Dec 12, 2024

Fixed in #17774 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants