Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v15 BlockList + inline editing + nested blocks is broken #17756

Open
dknippers opened this issue Dec 7, 2024 · 2 comments
Open

v15 BlockList + inline editing + nested blocks is broken #17756

dknippers opened this issue Dec 7, 2024 · 2 comments

Comments

@dknippers
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

15.0.0

Bug summary

BlockList with inline editing and nested blocks is broken. Nested blocks are added to the wrong block.

This occurs in at least 15.0.0 and 15.1.0-rc but perhaps other versions. It looks very similar to #17312 which was v14.3.0 so likely this has been broken for a long time. This seems to occur with any property that opens a modal, not just nested blocks. Like in the linked issue this happens with a URL picker but this probably happens with pretty much all pickers making this completely unusable.

In my case having a BlockList with inline editing and a block type that nests itself cannot be used as nested blocks are added to the wrong block. Have a look at the video, where I cannot add a Nested block to Block 2, they will always be added to Block 1.

Also note a bugged %1% label in the "Create Block for ..." button.

You can import these uSync files to reproduce it (will create doctype + element type + block list datatype)
uSync.zip

blocks

Specifics

No response

Steps to reproduce

See the video + attached uSync files to reproduce, but in short

  1. Add a block with a nested block
  2. Add a second block
  3. Try to add a nested block to block 2
  4. Observe it will be added under block 1 instead

Expected result / actual result

Working UI

Copy link

github-actions bot commented Dec 7, 2024

Hi there @dknippers!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

You're right, @dknippers , it seems to be the same problem as issue #17312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants