Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite Editor creates each save action a new version of content when content is invalid #12713

Closed
ealse opened this issue Jul 19, 2022 · 5 comments · Fixed by #12874
Closed

Comments

@ealse
Copy link

ealse commented Jul 19, 2022

Which exact Umbraco version are you using? For example: 9.0.1 - don't just write v9

10.0.1

Bug summary

When the Infinite Editor is used and the save button is clicked while the content is not valid there is a content item saved.
Each time the user is clicking on the save button the content is saved with a new ID.

I'm not quite sure if the save action shouldn't happen at all like a save and publish. But the double nodes are not good in any case.

Specifics

msedge_SHv5qMnkMO.mp4

Steps to reproduce

  • Create a clean Umbraco install following the guide (https://our.umbraco.com/documentation/Fundamentals/Setup/Install/)
  • Create a documenttype with a listview that has enabled the Infinite Editor and add a new documenttype below it.
  • Create in the Content section a new listview item.
  • And click as many times you want on the save button.

Expected result / actual result

No double items or no items at all.

@ealse ealse added the type/bug label Jul 19, 2022
@github-actions
Copy link

Hi there @ealse!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@ealse ealse changed the title Infinite Editor creates each save action a new version of content even if content is invalid Infinite Editor creates each save action a new version of content when content is invalid Aug 22, 2022
ealse pushed a commit to ealse/Umbraco-CMS that referenced this issue Aug 22, 2022
ealse pushed a commit to ealse/Umbraco-CMS that referenced this issue Aug 22, 2022
nul800sebastiaan pushed a commit that referenced this issue Mar 27, 2023
@nul800sebastiaan
Copy link
Member

Fixed in #12874

@thomashdk
Copy link
Contributor

thomashdk commented Dec 7, 2023

Umbraco 12.3.3.

Getting same issue in listview when "Infinite Editor" are enabled:

Umbraco save page error

Works fine if I hit "Save", then "Close" and open the node again.

@aguyfromdenmark
Copy link

I am experiencing the same problem as @thomashdk. I disabled "Infinite Editor" on my list view, and the problem went away. Using Umbraco CMS 13.3.2.

@ebouma
Copy link
Contributor

ebouma commented Jun 4, 2024

There is an open issue for this problem: #15945
The mentioned issue is not only related to content that is invalid.

There is already a pull request available at: #16280
hopefully it will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants