Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated ULID examples #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kachick
Copy link

@kachick kachick commented May 1, 2021

Hi! I'm writing a new Ruby library for handling ULID in these days.
Now I’m testing other implementations examples in kachick/ruby-ulid#53

And I have found weird examples in this original repository.

000XAL6S41ACTAV9WEVGEMMVR8 looks weird example from 2 reasons.

Returned values from current npm version looks correct.

$ node -v
v14.16.0
$ npm list
[email protected] /Users/kachick/repos/ulid-javascript
const ULID = require('ulid')
mf = ULID.monotonicFactory()
mf(150000) // 0000004JFG7NP20TJP26ZJDASS
mf(150000) // 0000004JFG7NP20TJP26ZJDAST
mf(150000) // 0000004JFG7NP20TJP26ZJDASV
mf(150000) // 0000004JFG7NP20TJP26ZJDAST
mf(150000) // 0000004JFG7NP20TJP26ZJDASW
mf(150000) // 0000004JFG7NP20TJP26ZJDASX
mf(100000) // 0000004JFG7NP20TJP26ZJDASY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant