feat: implement search highlight #205
Conversation
|
@snigdha-kansal Review please? :) |
|
@snigdha-kansal Did you get a chance to review this? |
There was a problem hiding this comment.
@ansh-saini sorry for the delay on this
one thing i observed: entering certain characters such as '\' '+' '*' '(' ')' or '?' in the search bar causes the app to crash
you can either reproduce it locally or at deploy preview
other than that, it looks great to me! thanks so much for working on this 💯
appreciate you going beyond to improve naming and formatting where possible!
|
Thank you for the review @snigdha-kansal |
|
@ansh-saini It looks great, thanks! 
|
|
Another great find @snigdha-kansal. |
|
Hey @snigdha-kansal Thank you for the approval. Also, just curious as to why you've approved this PR but not merged it. Is there something blocking the merge? |
|
@ansh-saini just added the label |
Fixes #96
I'm using the browser built-in mark tag to achieve the highlight. This will ensure standard behaviour on all operating systems.
Here's a screenshot of how it looks:
