Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exceptions (and catch and return them) instead of returning them directly as a string #515

Open
chuck-sys opened this issue Sep 29, 2020 · 0 comments
Assignees
Labels
theme:refactoring Something needs to be cleaned up or refactored

Comments

@chuck-sys
Copy link
Collaborator

Please give a one-sentence summary of the cleanup you would like done.
Raise exceptions and catch them outside of the handle helpers in commands.

Please give as many details as possible about the cleanup or refactoring.
We will need to raise exceptions instead of returning a string. This will be a medium-sized cleanup that shouldn't involve the tests if we do this right (by positioning the error handlers in the right place).

Please list any additional context; in particular, list what areas of the code base this would affect.
I don't think that helper functions need to handle/know about how to output errors and should just propagate it forwards.

@chuck-sys chuck-sys added the theme:refactoring Something needs to be cleaned up or refactored label Sep 29, 2020
@chuck-sys chuck-sys self-assigned this Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:refactoring Something needs to be cleaned up or refactored
Projects
None yet
Development

No branches or pull requests

1 participant