Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold cats-retry into CE 3? #1459

Open
cb372 opened this issue Nov 28, 2020 · 7 comments · May be fixed by #3135
Open

Fold cats-retry into CE 3? #1459

cb372 opened this issue Nov 28, 2020 · 7 comments · May be fixed by #3135
Assignees
Milestone

Comments

@cb372
Copy link
Contributor

cb372 commented Nov 28, 2020

Would there be any interest in folding the features of cats-retry (i.e. a few combinators for retrying effectful actions + a DSL for building retry policies) into CE 3? Would this be a good fit for the std module?

I have to admit up front that I probably wouldn't have time to lead this, but I'd be happy to support such an effort.

@djspiewak
Copy link
Member

I think this could be very interesting! Retry is an extremely common use-case.

@SystemFw
Copy link
Contributor

SystemFw commented Apr 7, 2022

@cb372 Hey Chris, actually I was thinking about this and didn't even know you opened an issue about it, I was going to reach out. Would you still be ok to lend your support/approval? I can do the necessary work to integrate if so :)

@cb372
Copy link
Contributor Author

cb372 commented Apr 7, 2022

Hi Fabio! That would be great. I haven't touched cats-retry in months so it's slowly rotting. I'd love to see it integrated into std where it can be properly maintained.

@SystemFw
Copy link
Contributor

Great, I'll open a PR then :)

@SystemFw SystemFw self-assigned this Apr 12, 2022
@djspiewak djspiewak added this to the v3.5.0 milestone Jun 12, 2022
@nullhappens
Copy link

@SystemFw I just recently made a contribution that adds one of the examples in the docs as a convenience for a RetryPolicy that is fairly common to use. Hope this makes it either into cats-retry or the next milestone of CE. Thanks for your hard work!

@SystemFw
Copy link
Contributor

I guess an official update is needed on this work as well. I've struggled with motivation for months trying to get the api to be slightly smaller (to have the appropriate footprint for CE), but I think I've finally hit a turning point, hopefully this isn't far away from completion. I'll try to include the example as well :)

@SystemFw SystemFw linked a pull request Sep 4, 2022 that will close this issue
3 tasks
@armanbilge
Copy link
Member

For anyone following along here: draft PR is up and seeking feedback :)

@armanbilge armanbilge modified the milestones: v3.5.0, v3.6.0 Feb 14, 2023
@armanbilge armanbilge modified the milestones: v3.6.0, v3.7.0 Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants