Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1661 #1662

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Issue #1661 #1662

wants to merge 5 commits into from

Conversation

patrickhrastnik
Copy link

I think this might be a valid solution for #1661 (and #1653 )... Let's see if Travis CI passes

I think this might be a valid solution for twitter#1661 (and twitter#1653 )
@androzd
Copy link

androzd commented Sep 14, 2017

dist not rebuilded

@kissifrot
Copy link

That'd be cool if this PR could be merged 👍

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
All committers have signed the CLA.

@kissifrot
Copy link

Why close if not merged?

@patrickhrastnik
Copy link
Author

I wasn't able to sign the CLA properly. I tried it several times, and yesterday I thought it doesn't matter anymore.
After I closed the pull request, the CLA status changed to "signed". Maybe if I reopen it stays that way - let's give it a try.

@patrickhrastnik
Copy link
Author

well - I signed the CLA, but it still says "pending" on the CI board above. I don't know how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants