fix: consider zero when retry_count not present #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Explanation
We're having some errors in the first failure of jobs with silent active because the
job_payload
won't have theretry_count
key if there were no retries. This is happening because Sidekiq sets theretry_count
key on thejob_payload
to zero only after the first failure of the job: see source. As a side note, observe that the first try doesn't count as a retry in theretry_count
, so, the way it's implemented today, thewarn_after
means warn after # of retries and not # of tries (first try + retry_count) in general.fix: #6