Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hardware capabilities in tests #21

Open
prusnak opened this issue Oct 8, 2019 · 1 comment
Open

Use hardware capabilities in tests #21

prusnak opened this issue Oct 8, 2019 · 1 comment

Comments

@prusnak
Copy link
Contributor

prusnak commented Oct 8, 2019

Let's replace code like this:

https://github.com/solokeys/fido2-tests/blob/2cc35f10cf4c1aa5be103d27d88397176a483ba9/tests/standard/fido2/test_resident_key.py#L180-L181

with something saner such as

@pytest.mark.skip_has_display
@pytest.mark.skip_truncates_displayName

This would also require defining a capability list for each supported hardware such as

capabilities = {
    'trezor': ['has_display'],
    'solokeys': ['truncates_displayName'],
}
@nickray
Copy link
Member

nickray commented Oct 9, 2019

This is a much better approach indeed! Ideally, we'd include capability lists for collaborating projects (or even hrmmm... wellknown others), while external users could somehow specify theirs when invoking the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants