Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more de-/serialization tests #54

Open
4 of 9 tasks
robin-nitrokey opened this issue Jun 24, 2024 · 0 comments
Open
4 of 9 tasks

Add more de-/serialization tests #54

robin-nitrokey opened this issue Jun 24, 2024 · 0 comments
Assignees

Comments

@robin-nitrokey
Copy link
Member

robin-nitrokey commented Jun 24, 2024

It is easy to break serialization, for example because enums are serialized using their variant index by default, byte slices are serialized as sequences of integers instead of hex strings, and reordering or removing fields can break serde-indexed. Therefore we should have basic de-/serialization tests for all requests and responses.

  • ctap1
  • ctap2
  • ctap2::client_pin
  • ctap2::credential_management
  • ctap2::get_assertion
  • ctap2::get_info
  • ctap2::large_blobs
  • ctap2::make_credential
  • webauthn
@robin-nitrokey robin-nitrokey self-assigned this Jun 24, 2024
robin-nitrokey added a commit that referenced this issue Jun 24, 2024
This patch adds de-/serialization tests for the modules ctap1,
ctap2::client_pin and ctap2::large_blobs.

See also: #54
robin-nitrokey added a commit that referenced this issue Jun 24, 2024
This patch adds de-/serialization tests for the modules ctap1,
ctap2::client_pin and ctap2::large_blobs.

See also: #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant