Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faker and BigQuery cleanups #24276

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Faker and BigQuery cleanups #24276

merged 2 commits into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. Revert "Increase allowed timeouts for BigQuery service" 

    This reverts commit 4d7522f.
The tests were made stable by other means instead of increased timeouts
and hence this commit's changes are unused.

For user-facing config the older values are sufficient and reasonable.
    @hashhar
    hashhar committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    82a242b View commit details
    Browse the repository at this point in the history

  2. Fix invalid scope in trino-faker pom 

    test-jar is not a valid value for <scope>. It's a valid value for <type>
however for trino-faker these dependencies' correct scope is runtime and
the type is jar.

Before this change the build logged a warning about this:

    Warning:  Some problems were encountered while building the effective model for io.trino:trino-faker:trino-plugin:466-SNAPSHOT
    Warning:  'dependencies.dependency.scope' for io.airlift:log:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 169, column 20
    Warning:  'dependencies.dependency.scope' for io.airlift:log-manager:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 175, column 20
    Warning:  'dependencies.dependency.scope' for io.trino:trino-client:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 181, column 20
    Warning:
    Warning:  It is highly recommended to fix these problems because they threaten the stability of your build.
    Warning:
    Warning:  For this reason, future Maven versions might no longer support building such malformed projects.
    @hashhar
    hashhar committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    9004d0a View commit details
    Browse the repository at this point in the history