Faker and BigQuery cleanups #24276
Merged
Faker and BigQuery cleanups #24276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d7522f. The tests were made stable by other means instead of increased timeouts and hence this commit's changes are unused. For user-facing config the older values are sufficient and reasonable.
test-jar is not a valid value for <scope>. It's a valid value for <type>
however for trino-faker these dependencies' correct scope is runtime and
the type is jar.
Before this change the build logged a warning about this:
Warning: Some problems were encountered while building the effective model for io.trino:trino-faker:trino-plugin:466-SNAPSHOT
Warning: 'dependencies.dependency.scope' for io.airlift:log:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 169, column 20
Warning: 'dependencies.dependency.scope' for io.airlift:log-manager:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 175, column 20
Warning: 'dependencies.dependency.scope' for io.trino:trino-client:jar must be one of [provided, compile, runtime, test, system] but is 'test-jar'. @ line 181, column 20
Warning:
Warning: It is highly recommended to fix these problems because they threaten the stability of your build.
Warning:
Warning: For this reason, future Maven versions might no longer support building such malformed projects.
hashhar
force-pushed
the
hashhar/random-cleanups
branch
from
2405204
to
9004d0a
Compare
nineinchnick
approved these changes
Nov 27, 2024
ebyhr
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts an un-needed and unused change in BigQuery.
Fixes pom for the trino-faker module.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.