Allow changing field type in records wrapped in a map #24248
Merged
+116
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
reviewed
Nov 25, 2024
| try (TestTable table = new TestTable(getQueryRunner()::execute, "test_set_field_type_in_map", tableDefinition)) { | ||
| assertThat(getColumnType(table.getName(), "col")).isEqualTo("map(integer, row(field integer))"); | ||
|
|
||
| assertUpdate("ALTER TABLE " + table.getName() + " ALTER COLUMN col.value.field SET DATA TYPE bigint"); |
There was a problem hiding this comment.
Potential follow-up:
Please consider documenting how to update the type of map key/value types on https://trino.io/docs/current/sql/alter-table.html
cc @mosabua
There was a problem hiding this comment.
#18546 is the relevant issue.
findinpath
reviewed
Nov 25, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Nov 25, 2024
ebyhr
force-pushed
the
ebi/core-set-column-type-map
branch
from
aad46e6
to
feb8f6a
Compare
losipiuk
reviewed
Nov 26, 2024
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Show resolved
Hide resolved
losipiuk
reviewed
Nov 26, 2024
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-set-column-type-map
branch
from
feb8f6a
to
aa50572
Compare
losipiuk
approved these changes
Nov 26, 2024
ebyhr
force-pushed
the
ebi/core-set-column-type-map
branch
from
aa50572
to
9d98c66
Compare
|
Going to merge as we already agreed on the syntax in #16959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support changing key and value types in MAP type with synthetic
keyandvaluefields.Relates to #16959
Release notes