Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When stats sending fails it sends a warning #8287

Open
arielshaqed opened this issue Oct 14, 2024 · 1 comment
Open

[Bug]: When stats sending fails it sends a warning #8287

arielshaqed opened this issue Oct 14, 2024 · 1 comment
Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) bug Something isn't working contributor good first issue Good for newcomers tech-debt

Comments

@arielshaqed
Copy link
Contributor

What happened?

What actually happened, including error codes if applies.

Steps to Reproduce:

  1. Run lakectl in an environment that cannot send statistics.

  2. Receive a scary warning message, e.g.

    $ lakectl repo list
    Warning: failed sending statistics: http: read on closed response body
    
  3. This confuses me and other users. The warning is confusing and has nothing to do with the success or failure of the actual command.

Expected behavior

Don't receive an error or a warning message when stats fails

lakeFS version

1.38.0

How lakeFS is installed

n/a

Affected clients

No response

Relevant log output

lakectl:

Warning: failed sending statistics: http: read on closed response body


### Contact details

_No response_
@arielshaqed arielshaqed added bug Something isn't working contributor area/lakectl Issues related to lakeFS' command line interface (lakectl) good first issue Good for newcomers labels Oct 14, 2024
@arielshaqed
Copy link
Contributor Author

Proposed resolution (discussed with several people around here): lakectl should complain about stats at level DEBUG, as should lakeFSFS and any other client. And go over lakeFS again to ensure that it doesn't complain about failing to send stats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lakectl Issues related to lakeFS' command line interface (lakectl) bug Something isn't working contributor good first issue Good for newcomers tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants