Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue @tierra's issue-sync branch #138

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cooljeanius
Copy link

I fixed the merge conflicts that tierra:issue-sync had with master. Closes #75 (or at least it ought to). Note that I haven't actually tested this myself, all I did was solve the merge conflicts.

tierra and others added 7 commits April 1, 2015 07:44
Extracted client_* config logic to GitHubMixin as well. It can
now be used for any github.* config key, but mostly just helpful
for "client_id", "client_secret", and "hook_secret".
- Creates a new ticket for all new pull requests.
- Automatically attaches patch from pull request.
- Attaches PR updates as new patches.
Also use DB variables for strings when necessary.
All issue and pull request comments are now posted to the
appropriate tickets as well as inline patch comments.
@cooljeanius
Copy link
Author

@tierra @aaugustin could one (or both) of you take a look please? I'm not quite sure how to test it... (which is why I haven't taken the PR out of Draft Mode yet)

@cooljeanius
Copy link
Author

@tierra @aaugustin could one (or both) of you take a look please? I'm not quite sure how to test it... (which is why I haven't taken the PR out of Draft Mode yet)

...actually I guess if #139 gets merged first, that'd be enough for me to take this out of Draft Mode...

@tierra
Copy link

tierra commented Nov 21, 2023

It's been quite a long time since I originally wrote this 8 years ago. Since then, my only Trac instance I was planning to use it for has since been decommissioned, with issues just one-time imported directly into GitHub. So I'm not even using what I wrote here, hence not following up on this.

Certainly feel free to complete the rest of this still. I just don't have the time or interest in helping with it though.

@cooljeanius
Copy link
Author

...actually I guess if #139 gets merged first, that'd be enough for me to take this out of Draft Mode...

...well, either #139 or #143, now, too... (merging both would help, but I think I'd only wait on 1 of them to be merged before taking this out of Draft Mode...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Feature: Issue Sync
2 participants