Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructive feedback #3

Open
dermorz opened this issue Aug 8, 2015 · 1 comment
Open

Constructive feedback #3

dermorz opened this issue Aug 8, 2015 · 1 comment

Comments

@dermorz
Copy link

dermorz commented Aug 8, 2015

Came here from:
https://www.reddit.com/r/netsec/comments/3g4mr2/nosql_exploitation_framework_v20/

  1. Try to stick to PEP8.
  2. Throw away the install.sh. This is a terrible way of installing python software, because it pollutes existing python installations with modules I would no want there and especially because it can't be installed as a user that way. Instead create a requirements.txt with the needed modules, so it's easy to create a virtualenv to run the frameworkscript. Or even better:
  3. Read up on packaging and distributing python projects and take the necessary steps. After that someone could easily install your framework via pip install nosqlexploitationframework.

Furthermore: Replace your cleanup.sh with a .gitignore file.

@torque59
Copy link
Owner

torque59 commented Aug 8, 2015

Hey,Thanks for bringing to my notice @moritzpein

  • I'll try following the PEP8 as much as possible,
  • As for the install.sh , i have moved to requirements.txt using pip and used .gitignore and briefed on virtualenv
  • As for packaging , i try in the next version :)

Many thanks for the suggestions , and looking forward for more feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants