Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: type-genearation (only for exports) (fixes #98) #104

Closed
wants to merge 5 commits into from
Closed

feat: type-genearation (only for exports) (fixes #98) #104

wants to merge 5 commits into from

Conversation

mathe42
Copy link
Contributor

@mathe42 mathe42 commented Sep 30, 2021

This PR is the 3rd try to implement this properly. And basicly it now is a simple change + let TS handle the rest.

Imports I have not covered as #102 will change evrything. There a simple cli-script with onyly argument that points to the WASM file can be written.

@torch2424 torch2424 self-requested a review October 25, 2021 16:41
Copy link
Owner

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! 😄

Thanks for this PR, I am super excited for it!

So the code looks great, and everything is fine there! But, I'm a little confused on how to test this. Could you share your test project with me so I can test it myself?

Or even better, could we create a project in: https://github.com/torch2424/as-bind/tree/master/examples , like something similar to https://github.com/torch2424/as-bind/tree/master/examples/quickstart , so we can even test it in the CI? 😄

Let me know what you think! Thanks! 😄 🎉

@janhelleman
Copy link

@mathe42 this feature looks great, could you provide @torch2424 with info?

@mathe42
Copy link
Contributor Author

mathe42 commented Dec 10, 2021

Sorry the amount of time I can put into this is currently very small. but I will add a small example within the next 10 days.

@mathe42
Copy link
Contributor Author

mathe42 commented Dec 19, 2021

@torch2424 Added a small example. (That is not runnable but we get full types)

Copy link
Owner

@torch2424 torch2424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathe42

My apologies for the super late reply! I wasn't checking Github at all during the holidays so I could spend time with family and things. 😄

This is looking great to me! 🎉 If you don't mind, after I merge this I'll probably do a follow up PR, to move around the package.json entry, as well as probably edit the README a little bit.

If you are okay with that, I'll go ahead and merge this, and make that follow up PR 😄 Thank you SOOOOO much for all the hard work here! 🙏🏾 😄 🎉

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants