Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to populate missing values when re-running build with more operators #77

Open
AustEcon opened this issue Aug 4, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@AustEcon
Copy link

AustEcon commented Aug 4, 2019

This is a really awesome tool! Thanks!

I found a bug playing around...

To reproduce this bug:

  1. Build e.g. last 10 commits
  2. Then specify e.g.:
    $ wily build name_of_folder -n 15 -o raw (which will add on 5 more rows to the table but only loc)
  3. Then you will see that:
    $ wily report name_of_folder
    will show Not found 'cyclomatic' Not found 'maintainability' and Not found 'halstead' (as expected)
  4. But THEN, if you do:
    $ wily build name_of_folder -n 15 -o raw,maintainability which does nothing or
    $ wily build name_of_folder -n 20 -o raw,maintainability which correctly populates the next 5 rows of the table but does not identify the fact that there are missing values in previous rows that also need to be filled...

Seeing as though this script takes quite a while to run, I think it would be optimal if it behaved in a way such that it would recognise missing data and fill in the blanks before proceeding with new rows. What do you think?

Or am I not entering commands correctly?

@tonybaloney
Copy link
Owner

thanks @AustEcon

The build command doesn't compare the revisions, it considers them write-once-read-many.

This was design because running the index for any revision is time-consuming.

But, the index does store a list of metrics for each revision, so potentially it could compare that with the list of requested operators and re-index any revisions.

The report command should ignore revisions that have missing data values though, so I'm going to test the scenario you've explained

@tonybaloney tonybaloney added the bug Something isn't working label Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants