Support download and install games from the Humble Monthly Trove #32
Comments
neuromancer
changed the title
|
It should be possible if they have some API to access Trove. But probably they have no such API. In this case it probably can be implemented with HTML parsing. Btw I can't try to implement it now as I don't have active Monthly subscription and this month's games don't look interesting enough to subscribe. |
|
Yes, they don't have an API, but fortunately, there is an Python implementation that shows how to parse the HTML and extracts the links here. |
|
Does Trove have any good games? How many of them are working on Linux? Is it even worth implementing? |
|
I counted from my trove and half of the games have Linux support. Some others are Windows only, but they could work in Linux (e.g. Indiana Jones® and the Fate of Atlantis™). |
|
@neuromancer Test 9e3dc15. |
|
It works as expected with the free games (my subscription is not active this month, thanks to a Paypal issue), but I will test with full set of games in the near future. |
|
Btw, after tomorrow, the free games are not going to be available for downloading, but we will have them already installed. Do you this change will be handled correctly? |
|
I'm not sure, but we'll see. If signed urls will continue to work, you should be able to download games even after they will disappear from Trove. Links seem to have some TTL. |
|
They have redesigned Trove page. It seems now it's impossible to extract full game info and download links from this page, as game info is now shown in a popup created by js. js probably makes some ajax calls so it's possible that these calls may be captured. I'll take a look in a few days. |
|
I think Humble Trove should not be a priority, in case you think it won't be easy to maintain, feel free to remove it. |
|
@neuromancer Humble Trove should work again, but I currently don't have monthly subscription to actually test downloading. |
|
I re-tested and I can see the new icons (they look great, as good as steam/gog ones), but I don't have subscription either. I guess they shoudn't show in the list if your subscription is not active.. |
|
The titles that I only have via trove can't install. --debug shows nothing when attempting. No install window loads. |
|
@Sanaki do you actually have an active Humble Monthly subscription? |
|
I do. And just for kicks, I verified I can manually download titles from the trove page. |
|
@Sanaki it may be related to #57 (comment). Try to open game's details, wait for some time, then reopen details and try to install it again. Or try previous release before update phase was disabled: 0.13.0-6-dev. |
|
Neither helped. This is true of both windows and linux native games. |
More verbose logging for Humble Trove with `--verbose` option (#32)
|
@Sanaki more verbose logging for Trove was added in 3c67adf. It should help to identify your problem. Update to 3c67adf and run You should see lines like these (can't sign URL): or like these (URL signed successfully): You should be able to download Trove games if you have a subscription and it's possible to successfully get signed download URL. |
|
Opening properties will cause two instances of Opening details only causes Clicking install within details or clicking the tile in the main window produces no messages whatsoever. The only other noteworthy errors were a pile of cached icon failures, such as: |
|
Run |
That might be the problem. You can try to escape/unescape slashes manually using |
|
@Sanaki does your Humble token contain |
|
Well, current value shows double backslashes, custom value shows singles. Presumably it's just a display error, but seeing it disparately in the same window is a bit... odd. Unless you know a different editor with more consistent behavior, not sure I can give you a straight answer on that point at the moment. I'm not sure how easy or efficient it would be to add a line to locate and strip any double backslashes from the token before attempting to use it, but that would be the easy answer from my perspective. As for the _simpleauth_sess route, no change. My cookie did have quotes surrounding it which I stripped out, but I did verify I was fully logged in. Both tokens do contain \075. That's where the double backslashes are coming into play. I tried manually replacing \075\075 with == in the token and got no change in behavior, but I realize that may be to be expected. |
|
@Sanaki try latest version. Run Watch log lines like: It's a bit hard to test for me as my tokens never contain |
|
[DEBUG] [WebAuth/Humble Bundle] [Cookie] Immediately followed by crashLoads fine on reopen, still no luck actually attempting to install a trove game. Just in case this detail has been lost in the noise, humble bundle titles work fine. Just not humble trove. |
That's weird. I don't know how can it be fixed and what is even wrong then. As I said, I'm not able to test it with my own account. It would help if you had temporarily gave me credentials of a problematic account to test (with removed sensitive information, disabled 2FA and changed email/password of course). Send them to my email if you want to do this. |
|
Hello @tkashkin I did a test with the latest dev version (0.14.2-29-dev-2a7ac4c) appimage. I'm not sure if the detection are ok, it show only a few games but when I try to filter on some title I find them back in my HB Library so maybe GameHub did a merge to just show me the Trove games I not have in my HB Library. The download/install fail, it say to check if my subscription is active. Have a nice day. |
|
@kadogo try #32 (comment) to see if GameHub is able to get signed download URLs. |
|
@tkashkin sorry for my answer time. I just download the dev version but I see nothing related to URL in my terminal I just see a notification when I click on install saying |
|
@kadogo add |
|
I tried with debug option, I have few more things in begin but nothing new when I try to install a humble trove game |
|
@kadogo looks like |
|
True, now I see "old url" and "new url" |
|
@kadogo so signed url is correct, but GameHub still doesn't download the game? Is there anything else in log? |
|
Exactlly, I see in the terminal And if I open in in my browser it work, but GameHub don't download it |
|
Hey. This is really cool for those with access to the Trove. But I don't, and the games from there still shows up. That's confusing and unnecessary. Could this be fixed? I'm logged in to my Humble account, but I don't have Trove.
|
|
@forteller disable "Load games from Humble Trove" option in Settings > Humble Bundle. |
|
Thanks! Is there no way of detecting this and only turn it on if you actually have access to it? |
Former-commit-id: 9e3dc15
Former-commit-id: 9d040db
Former-commit-id: 4798294
More verbose logging for Humble Trove with `--verbose` option (tkashkin#32) Former-commit-id: 3c67adf
Former-commit-id: 3dd7dbe
Update Humble Trove parsing (tkashkin#32) Former-commit-id: 480c20f
Fix Proton prefix initialization Former-commit-id: 6057e0f
https://www.humblebundle.com/monthly/trove
The text was updated successfully, but these errors were encountered: