Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in sunfish_nnue.py lines 217 and 261 #120

Open
foo123 opened this issue Sep 20, 2024 · 2 comments
Open

Typo in sunfish_nnue.py lines 217 and 261 #120

foo123 opened this issue Sep 20, 2024 · 2 comments

Comments

@foo123
Copy link

foo123 commented Sep 20, 2024

Line 217 is:

old_ep, old_kp, old_wc, old_bc = self.ep, self.kp, self.ec, self.bc

instead of self.wc (Position field) it has self.ec (no such field)

similar for line 261

@thomasahle
Copy link
Owner

Good point. The nnue version just isn't working well yet. But this would be good to fix.

@foo123
Copy link
Author

foo123 commented Sep 21, 2024

I have made a javascript port of sunfish: sunfish.js and have ported both sunfish.py and sunfish_nnue.py versions.

I have also added maxdepth (eg go depth x) and stop uci options since they are needed in js. Other than that (and possibly some typos) I left the code as similar to py code as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants