-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Drupal 10 #52
Comments
Created a branch based of 9.x. no major changes. Using Drupal10 recipe https://docs.lando.dev/config/drupal10.html Known Issues WARN ==> drupal10 is not a supported recipe type.
|
@joshua1234511 We added Drupal 10 support in the 3.6.2 pre-release Please make sure that your on at least that version. |
@labboy0276 Please note that this issue is about creating a |
oh ok |
I am not sure how exactly it is supposed to be done, but basically just a clone of And then tweak |
yes; @gitressa #11 is how to do it. @labboy0276 can you create a |
@gitressa @serundeputy the 10.x branch is ready to go: https://github.com/lando/drupal-contributions/tree/10.x I didnt make it the default branch since D9 is still the current version and stuff. |
Thanks, @labboy0276. I just gave the 10.x branch and got a couple of errors during the build and end up with a non-functional build (404 Not Found errors going to the provided URLS). Full log of
|
Thanks @labboy0276 for making the branch and adjusting versions. I agree that it makes sense to wait a bit with making I have also been seeing similar issues while testing the Drupal 10 recipe: After Lando says "Your app has started up correctly. Here are some vitals:" and I run a Drush command, it sometimes fail (I forget the error message). If you wait a few seconds and issue the command again, it works. It's as if some parts of Docker are not ready, when the next command is run first. Also, with Drush I get this response:
But
|
I can take a look a little later. I got everything to install ok, I didnt test much further than that. |
This new There are two minor issues, I don't know how important they are: Yarn warning
Composer warnings It seems like the |
@cdubz Perhaps you can share your environment?
|
I'll give it another go a little later today. Dealing with work production deployments ATM (: I'm using Lando 3.6.2 on macOS and my guess is that my first attempt just choked Docker... as happens sometimes on macOS. Hopefully next go around will be successful for me as well. |
@gitressa my 10.x branch is on the latest version of composer. All php 7.4+ image should be by default:
|
@cdubz Ah yes, macOS can be challenged performance-wise with Docker ... This nugget, which purges all Docker containers and Lando cache was just shared by @generalredneck in https://gist.github.com/labboy0276/4406db072f9ed3bf3641f57c1d902027 and added by @labboy0276, if you ever feel like a fresh start: https://docs.lando.dev/help/purging-containers.html#purging-command |
@labboy0276 It's strange I am getting drupal10
drupal-contributions
Maybe I should try the Purging command for a fresh start ... |
So I removed everything with the Purging command, and even deleted the What's interesting is that during both installations, it looks like Composer
@labboy0276 I note that you write
PS. The Drush issue was just fixed and a fresh version 11.0.7 released, very nice. Thanks @weitzman! |
yeah not sure, it install 2.2.6 on my end within the drupal-contrib repo. |
Second go at install was a success 🎉 I do also have Composer 2.0.7 and PHP 8.1.3 --
|
Setting a
gets me the latest Composer version (2.2.7). Hm... |
@cdubz Interesting 🤔 Like I wrote, this flashes by during install of both drupal-contributions and a singular
Also, I get this: drupal-contributions (Composer
So two questions:
My first hunch would be to not install Composer Do you have any idea how to prevent this @labboy0276? |
I can answer why that happens. Drupal requires composer/composer in drupal/core-dev. Lando has /app/vendor/bin as the first path in $PATH. So the version in /app/vendor/bin downloaded by installing Drupal is overloading the one in /usr/local/bin/composer. My work around before was to remove the drupal/core-dev package. |
@gitressa Lando installs composer in the php container. As @generalredneck pointed out, my guess is the funkiness is due to something within this repo or Drupal installing something not the best way via composer. However, I am still getting the right composer version on my end:
I don't see the Maybe @serundeputy has more insight since he built a good chunk of this repo. |
running |
I think I can explain this...The lamp recipie's default configuration shows composer 2.0.7 You can see that here: https://github.com/lando/lamp/blob/9524d6e78a8f42a224c2fe3078b2c5cc6d74c545/docs/config.md#L16 That trickles down into this recipe. (correct me if I'm wrong), but since drupal-contributions does a get-drupal it does a composer install on the composer file inside /app/web. composer/ccomposer is in require-dev of the composer.json file there... therefore you will always get composer/composer:^2.2.4 in this case after the initial install... HOWEVER since the vendor directory ins in /app/web/vendor and not /app/vendor (as that folder doesn't exist) you use the version in the global install see $PATH
|
@generalredneck that doc is out of date. The LAMP/LEMP recipes install the composer that is defined in the php images for that version. |
I can confirm though that with the .lando.yml provided in this project, on lando 3.6.2 I'm getting composer 2.0.7 though by default... |
This is the PR for Still, where does Composer |
|
My guess is your images are old. I am not seeing them on my local. |
Burned docker to the ground and cleared lando cache running the documentation we talked about yesterday and still getting composer 2.0.7 |
and you are version 3.6.2 of Lando? |
Hmm I dont think the latest php stuff got into 3.6.2. It is earmarked for 3.6.3 If you run from source do you still have the same issues? |
so yeah lando 3.6.2. and composer 2.0.7. But at least now we know that's where it came from and at least for me I've shared my knowledge on why on a normal drupal 10 recipe install using composer you get composer out of /app/vendor/bin... I don't know where this all fits into documentation though... as I think that's literally the next logical step. |
yeah so my bad @generalredneck @gitressa I run Lando from source. The issue lies here: https://github.com/lando/php/pull/25/files#diff-8f3653a6dff688ba1460548a7abc453cb3cb60ddd3848a22ee2ac73b8b8769b9L113 Our images are already on 2.2.6 while the php service in Lando 3.6.2 still runs with 2.0.7 in the 0.5.1 version of the php plugin. The 0.5.2 has the right hotness and that will be in Lando 3.6.3 |
Ah, good to get this cleared up, I'm looking forward to Lando 3.6.3. |
Thanks for releasing Lando 3.6.4, the Drupal 10 recipe works well, and the PHP image installs PHP 8.1.4 and Composer 2.2.12. As a side note, Composer is updated to 2.3.5 during
Composer 2.3.5 required on
The remaining tasks for Drupal 10 support (see Issue Summary) are to update versions and patch examples in the README.md file. |
@gitressa what happens if you set the |
With
I can stick to
|
With the last MR's getting merged, last outstanding |
I've read through the thread and don't understand why this issue is closed. For me, it's still a problem. Here are the steps:
Here is the outputted error. Notice there is no Drupal 10 in the recipe choices.
|
Please note that this is the Lando + Drupal Contributions repository:
lando/drupal is probably where you want to open a new issue. |
I just needed to install Drupal 10 ... so perhaps a
10.x
branch can be created here?Since there are no fundamental changes between D9 and D10, the D9 branch for
lando/drupal-contributions
can easily be tweaked for D10, and when thedrupal10
Lando recipe is ready, we can update it. See also #5.10.x
branch and adjust versionsREADME.md
file (Updates version in README.md for Drupal 10 #60)README.md
file (Update Test a Contrib Module Patch example in README.md file for Drupal 10 #62)git clone
branch inREADME.md
(Fix branch in clone command, update Test a Core Patch #61)README.md
file (Fix branch in clone command, update Test a Core Patch #61)The text was updated successfully, but these errors were encountered: