Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repository status page styles break when repo is moved #430

Open
jku opened this issue Sep 5, 2024 · 1 comment
Open

repository status page styles break when repo is moved #430

jku opened this issue Sep 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Sep 5, 2024

compare
https://sigstore.github.io/root-signing/index.html
vs
https://tuf-repo-cdn.sigstore.dev/index.html

This is because

  • tuf-on-ci only produces the index.md, the html is then produced from markdown with jekyll
  • jekyll really, really likes using absolute URLs so the css URL is /root-signing/assets/css/style.css?v=a4b685e8705fdb5078638a18dbea969788c0036d

when the repository is moved even if we also move the stylesheet, this absolute path is incorrect.

Possible fixes:

  • get jekyll to use relative paths -- this seems impossible
  • hack the html after it is generated -- this is not trivial since the the html is in metadata dir whereas the stylesheet is not...
  • produce the html in tuf-on-ci directly -- this is likely best alternative but I don't have the skills
  • use something else than jekyll -- I chose jekyll-build-pages only because it's a 1st party action.

I think the last option might be worth looking into: we could e.g. make tuf-on-ci-build-repository depend on python-markdown and do the conversion there, or use the docker://pandoc/core:2.9 action

@jku
Copy link
Member Author

jku commented Oct 31, 2024

jekyll also breaks the "Improve this page" link at the bottom (this happens even on github pages). It does not seem configurable when using the action but it's possible I've just missed something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant