Added hacky drop-down with "replace all instances" on color rows

[AKAStacks]

I probably need help on this; but I really want to be able to change all matching colors in the ColorsList globally somehow. With this pull, you can functionally right click on a colorbutton and all rows with matching colors will also be changed to the selected color.

It's a small modification, but it's definitely not done the correct way. Please point me in the correct direction.

Modified colors_list.OomoxColorButton:

• changed init so that on_click is linked to "button_pressed_event" event vs. "clicked" signal to allow to detect left(1) vs right(3) click
• implemented get_listbox_parent to reference button's parent ListBox object
• changed colors_list.OomoxColorButton.on_click to use the above to iterate through sibling listboxrows and modify those that match the original value
• had to modify colors_list.ColorListBoxRow.set_value func, adding a kword arg so that it would stay connected to update the preview the way I wanted

[actionless]

instead of implicit right-click action it should be a linked dropdown button with menu, with at the moment only one menu item "Replace all occurrences", so users could know what there is an extra action attached to color button

that would also help to avoid most of the modifications

[actionless]

also, dropdown anyway will be needed for #112 and few other planned features

[AKAStacks]

Thank you for the feedback--I'll work on this tomorrow. :)

[actionless]

i was speaking about linked dropdown button, not right-click menu

[AKAStacks]

I do not see this in my environment; the color_entry boxes are essentially simple text boxes. In fact, in my environment the octothorp isn't even present in the value, for example https://imgur.com/X3HvXML.png.

I'll look more into this tomorrow, and how it might be implemented on a Gtk.Entry object or however it will need to work.

[actionless]

it's currently a linked group of text entry and color button

to the same linked group should be added a third item, a dropdown button with menu

ignore the octothorp, that's not related to the point, that's not a screenshot from oomox, but a demonstration of how linked entry with dropdown button look like

[AKAStacks]

I apologize: I'm not a programmer by trade, and this is my first "contribution." I didn't grok/understand your ("linked" (style)) terminology until I searched a bit. I feel I have accomplished what you've requested, except "avoiding most of the modifications" a la your first review.

[actionless]

please swap places of menu_button and color_button (so the dropdown will be rightmost)

[actionless]

that's bad you ignored the warning -- it seems it should be:

self._menu_item = _menu_item

[actionless]

by "avoiding most of the modifications" i meant exactly the state of your PR as it is now :)
without extra hacks for handling right click

[actionless]

however it doesn't seems you need this line at all, as _menu_item is not used next in the code

[AKAStacks]

Thank you for your (extra) help. Let me know if you want any other modifications. I love this piece of software. 👍

[actionless]

thanks for your dedication on polishing the pull request!

[AKAStacks]

It bothers me that this fails the Travis "build;" I would like to assist with some other functionalities. I think, at this point, that makes you a Senior Software Engineer.

[actionless]

Oops, after adding translation support the line became too long

…

On Sat, 29 Feb 2020 at 08:08, Dennis Zarger II ***@***.***> wrote: It bothers me that this fails the Travis "build;" I would like to assist with some other functionalities. I think, at this point, that makes you a Senior Software Engineer. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#285>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMUG5OEKLNERXORE3GXU63RFCZ6TANCNFSM4KZUYMNQ> .

[actionless]

green again :)
f7745f5