Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Feature Request: Implement dotnet cli (net.core) #255

Open
MarcoGriep88 opened this issue Oct 30, 2019 · 12 comments
Open

Feature Request: Implement dotnet cli (net.core) #255

MarcoGriep88 opened this issue Oct 30, 2019 · 12 comments

Comments

@MarcoGriep88
Copy link

MarcoGriep88 commented Oct 30, 2019

I really like the Python Version for Theia. Is there any plan to create dotnet cli support for the terminal?

@sr229
Copy link
Contributor

sr229 commented Oct 30, 2019

It should be easy as just writing a stack for it and install the .NET Extension. We did it over at gitpod.io and it works quite excellently.

@vince-fugnitto
Copy link
Member

@MarcoGriep88 sounds interesting, have you taken a look at .NET Core and VS Code?
The same should be true for Theia.

@sr229
Copy link
Contributor

sr229 commented Oct 30, 2019

@vince-fugnitto I'll test it out first on Gitpod.io and see if I can carry it over to here

@vince-fugnitto
Copy link
Member

@vince-fugnitto I'll test it out first on Gitpod.io and see if I can carry it over to here

Thank you! I appreciate it 👍

@MarcoGriep88
Copy link
Author

Ok, i have an Dockerfile. But i am not allowed to push it. Not even to an new Branch. Can i just post it here?

@vince-fugnitto
Copy link
Member

@MarcoGriep88 have you forked the repository?

@MarcoGriep88
Copy link
Author

MarcoGriep88 commented Oct 30, 2019

Yes, i my fork it works fine.
https://github.com/MarcoGriep88/theia-apps

@MarcoGriep88
Copy link
Author

Yes, i my fork its possible.
https://github.com/MarcoGriep88/theia-apps

@vince-fugnitto
Copy link
Member

@MarcoGriep88 it should be possible for you to open a pull request, I went to your fork and did it
#256 :) I'll close it in favor of you opening it.

@marcdumais-work
Copy link
Member

Hi @MarcoGriep88 ,

At a quick look it seems your image is a fork of our full image. That's not ideal since we now would have 2 images to update whenever we find a problem with the full image.

Instead, you should consider one of the following:

  • extend the current full image and add just the changes you need to cover dotnet. e.g. start your docker file with "FROM theiaide/theia-full:latest" and just add the "delta" you need and potentially a new entrypoint if needed.
    or
  • integrate your changes in the existing full image. It already supports many languages, and we can add more

@MarcoGriep88
Copy link
Author

MarcoGriep88 commented Oct 31, 2019 via email

@marcdumais-work
Copy link
Member

Hi @MarcoGriep88

Thanks, I will try this. I am not that experienced with Docker :)

No problem - let us know if you have questions or need help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants