-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Action wrappers to make sure they can represent any interactor #144
Comments
Also, I think we'll need to be able to remove a wrapper too right? |
@cowboyd What wrapper do you mean? |
@wKich I'm referring to the action wrapper and that it receives enough information to render the storybook step. |
But why do we need to be able to remote it? |
I'm not sure what you mean by remote it? |
I mean that you said |
Ah yes, remove, not "remote". The answer is flexibility and embeddability. If we don't have the ability to remove it, then we cannot safely use it at any other scope other than the global scope. For example, it lets us scope the action wrapper to the context of the storybook interaction. onPlay((step, signal) => {
let remove = addActionWrapper(createWrapper(step));
signal.addEventListener('abort', remove);
}) |
Oh, sorry. I didn't notice, that I did a typo :) |
In order to integrate with the storybook debugger, we need to be able to represent interactors in code form and not just in text description form. Currently, an interactor sequence such as
will be rendered in storybook as:
That's because the current facilities to generate a textual representation of interactors is optimized for rendering user-readable errors inside the test failure output. However, we want to be able to render the interaction as close to code as possible, so that the storybook output looks like:
This issue is set up to track that we have the pieces in place to do this:
The text was updated successfully, but these errors were encountered: