From 347f99f02207467459f242c4240fc55f642ae1d1 Mon Sep 17 00:00:00 2001
From: Michael Moll <kvedulv@kvedulv.de>
Date: Sun, 30 Jun 2019 14:29:44 +0200
Subject: [PATCH] update rubocop to 0.72.0

---
 .rubocop.yml      |  4 ++++
 .rubocop_todo.yml | 50 ++++++-----------------------------------------
 Gemfile           |  4 +++-
 3 files changed, 13 insertions(+), 45 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 919957d..b61f7cc 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,3 +1,7 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+
 inherit_from:
   - .rubocop_todo.yml
 
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 297cf08..baae034 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,12 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-11-11 15:08:09 +0100 using RuboCop version 0.60.0.
+# on 2019-06-30 14:26:46 +0200 using RuboCop version 0.72.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
+# Configuration parameters: AllowComments.
 Lint/HandleExceptions:
   Exclude:
     - 'lib/foreman_xen/vnc_tunnel.rb'
@@ -23,58 +24,19 @@ Lint/UnusedBlockArgument:
   Exclude:
     - 'lib/foreman_xen/engine.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'app/models/concerns/fog_extensions/xenserver/server.rb'
-    - 'app/models/foreman_xen/xenserver.rb'
 
-# Offense count: 5
+# Offense count: 4
 Lint/UselessAssignment:
   Exclude:
-    - 'app/helpers/xen_compute_helper.rb'
     - 'lib/foreman_xen/vnc_tunnel.rb'
 
 # Offense count: 16
-Metrics/AbcSize:
-  Max: 67
-
-# Offense count: 1
-# Configuration parameters: CountBlocks.
-Metrics/BlockNesting:
-  Max: 4
-
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 367
-
-# Offense count: 3
-Metrics/CyclomaticComplexity:
-  Max: 12
-
-# Offense count: 21
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/MethodLength:
-  Max: 52
-
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ModuleLength:
-  Max: 111
-
-# Offense count: 1
-# Configuration parameters: CountKeywordArgs.
-Metrics/ParameterLists:
-  Max: 6
-
-# Offense count: 4
-Metrics/PerceivedComplexity:
-  Max: 13
-
-# Offense count: 4
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db
 Naming/UncommunicativeMethodParamName:
@@ -82,10 +44,10 @@ Naming/UncommunicativeMethodParamName:
     - 'app/helpers/xen_compute_helper.rb'
     - 'app/models/foreman_xen/xenserver.rb'
 
-# Offense count: 19
+# Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: when_needed, always, never
+# SupportedStyles: always, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
diff --git a/Gemfile b/Gemfile
index ffa7165..b44ba5d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,4 +2,6 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rubocop', '~> 0.60.0', require: false
+gem 'rubocop', '~> 0.72.0', require: false
+gem 'rubocop-performance', '~> 1.4.0', require: false
+gem 'rubocop-rails', '~> 2.1.0', require: false