can't change the completeMessage text

[hiddevdploeg]

Hi,

First of all great job! I Love the simplicity of this.

For some reason my completeMessage is You’ve been added to our list. X instead of the text I defined as completeMessage={"Thanks for subscribing!"}

Any idea how this is possible?

[iamkevingreen]

@hiddevdploeg could you share the whole rimp snippet (minus your mailchimp key). The above should work just like the other fields.

[hiddevdploeg]

Sure thing! Here goes:

        <Rimp
          buttonValue={`Sign Up`}
          buttonStyles={`cta`}
          containerStyles={`forms`}
          mailChimpUrl={url}
          placeholder="Enter your email address"
          completeMessage={"Thanks for becoming a changemaker!"}
          showError={false}
        />

[iamkevingreen]

@hiddevdploeg I believe the quote syntax you are using may be wrong. Could you try instead of the double quotes to use the ticks, or remove the brackets from wrapping the string? so either:

completeMessage='thanks for becoming a changemaker!'

or

completeMessage={`Thanks for becoming a changemaker!`}

[hiddevdploeg]

For some reason I still get this:

[iamkevingreen]

@hiddevdploeg can you tell me what version of rimp you have in your package.json?

[hiddevdploeg]

0.1.7

[iamkevingreen]

mmm... that was from the initial release of 0.1.1, i'm also using the version you listed on another site without issue. Could you try removing the package and readding it. Also check the contents of the node_module folder and ensure that the text above is not there?

https://github.com/the-couch/rimp/blob/master/package/index.js#L138 <-- this is correct

[hiddevdploeg]

For some reason I did find it in the index.js and it's fixed now 👍 Thanks

[hiddevdploeg]

Not sure how this happened, I did re-install it and it was still there

[iamkevingreen]

I'll take a look at the npm version, but this is pretty legacy, are you using npm or yarn? @hiddevdploeg

[hiddevdploeg]

Yarn

[hiddevdploeg]

Other than that it's brilliant. Any way I can get the GDPR things pop up or link mailchimp confirmation screen? I'm afraid it's legally not allowed to add people directly to a list, no?

[iamkevingreen]

You should still get the confirm email in your inbox unless you have that disabled. The purpose for this package is to allow for clientside subscribing without the need to take users to the confirmation page. Otherwise you can't do the like clientside hey thanks for subscribing if it takes you to another page. If those concerns are real for you, you should just use the normal embed code provided by mailchimp and not do an ajax style clientside request.

This can usually only be achieved when using server side mailchimp api. However this is an undocumented solution.

Alternatively open to ways to make this more accessible!

[camsjams]

The source code on npm for version 0.1.7, has the dist.js as:

  _react2.default.createElement(
          'p',
          null,
          'You\u2019ve been added to our list. X'
        )

Rather than using this <p>{this.state.completeMessage}</p> as shown in this Git repo.

[iamkevingreen]

will take another look at this @camsjams i think npm just hates me 🤔

[michaeldever]

Also seeing this issue using yarn.