Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust min/max timestamp in querier #486

Open
GiedriusS opened this issue Sep 19, 2024 · 3 comments
Open

Adjust min/max timestamp in querier #486

GiedriusS opened this issue Sep 19, 2024 · 3 comments
Labels
Prometheus 3.0

Comments

@GiedriusS
Copy link
Member

Basically, we should port prometheus/prometheus@debbdb8 into our engine. It breaks lots of tests.
@GiedriusS GiedriusS changed the title Adjust min/max timestamp in querier [Prom 3.0] Adjust min/max timestamp in querier Sep 19, 2024
@GiedriusS GiedriusS changed the title [Prom 3.0] Adjust min/max timestamp in querier Adjust min/max timestamp in querier Sep 19, 2024
@GiedriusS GiedriusS mentioned this issue Sep 20, 2024
Merged
@fpetkovski
Copy link
Collaborator

fpetkovski commented Sep 21, 2024 •
edited
Loading

In theory we should be able to do this by modifying the logic in the ringbuffer package and perhaps the prometheus matrix_selector scanner.

@yeya24
Copy link
Contributor

yeya24 commented Oct 2, 2024

Is it still blocked by prometheus/prometheus#14961? I see the issue was closed.

@fpetkovski
Copy link
Collaborator

Looks like that was a false alarm, we can try to update and make the necessary modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Prometheus 3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fpetkovski @GiedriusS @yeya24