Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moose compile: put rmp_serde under feature flag #1020

Open
mortendahl opened this issue Mar 30, 2022 · 0 comments
Open

Moose compile: put rmp_serde under feature flag #1020

mortendahl opened this issue Mar 30, 2022 · 0 comments

Comments

@mortendahl
Copy link
Member

We see that ~7% for the generated LLVM code is related to rmp_serde

357926 (6.1%)     258 (0.2%)  <&mut rmp_serde::decode::Deserializer<R,C> as serde::de::Deserializer>::deserialize_any
139718 (2.4%)    4356 (3.9%)  core::ops::function::FnOnce::call_once
104948 (1.8%)    1484 (1.3%)  alloc::alloc::box_free
 85110 (1.5%)    4177 (3.8%)  core::ops::function::FnOnce::call_once{{vtable.shim}}
 83337 (1.4%)    1651 (1.5%)  <core::result::Result<T,E> as core::ops::try_trait::Try>::branch
 69237 (1.2%)     258 (0.2%)  rmp_serde::decode::Deserializer<R,C>::read_str_data

and it might be worth to see if making it optional gives us much in terms of rustc performance when compiling Moose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant