Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add some setting options. #53

Open
Abhinav1217 opened this issue Jan 23, 2020 · 2 comments
Open

Feature Request: Add some setting options. #53

Abhinav1217 opened this issue Jan 23, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Abhinav1217
Copy link

I just tried latest commit from master. A lot of bug has been resolved, so looking forward for new release.

Currently Settings option only contain a theme switching. Here are some suggestions which I feel would fix some minor issues. Refer to the screenshot below.

  1. Currently there is no limit on how many decimal places to show (even for repeating values). An option to configure that would be a treat. Google by default round up to 4 digits. Most daily home use case would prefer to be rounded to 2 digits. This will resolve a minor issue I am mentioning in next point.

  2. The result after divider is nice. But showing units messes it up because of long decimal value. For example when I convert 10 meter to feet. The unit feet moves to second line and overlaps with the result of next operation. (See screenshot). I think having a gutter on right which will hold units, would be nice separation between values and its units.. Also there is an ISO 2848 which defines globally accepted symbols and units for measurements. No more foot vs feet debate.

  3. At the bottom of the app, there is a Total: section. Which shows combined results from all the operations above. I didn't see it in the older released appimage, so either its a testing thing or a new feature. If its a new feature, as you can see in screenshot, whenever we calculate something which contains string for units, it messes it up.

  4. This is not a bug, but more like a bad UI choice, When you click hamburger to go to settings, It is not clear how to get back. The close button is located in position of actual close button suggesting clicking it will close the app. Replacing it with a back arrow will make it's intention more clear.

Screenshot from 2020-01-23 11-33-54

@sarthology
Copy link
Collaborator

@Abhinav1217 Great suggestions.Thanks, Keep posting stuff. I will try to address these issues in upcoming PRs.

@sarthology sarthology added bug Something isn't working enhancement New feature or request labels Jan 23, 2020
sarthology pushed a commit that referenced this issue Jan 27, 2020
* Makes the divider resizable added #52

* maxPanelSize changes when app size changes.

* Fixes issues related to #53

* Added the feature of brackets and quotes #38
@sarthology
Copy link
Collaborator

@Hardik500 Your PR solved most of the bugs Expect the 3rd.

Screenshot 2020-01-27 at 2 23 27 PM

Also I think this might be another problem we can address.

Screenshot 2020-01-27 at 2 24 10 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants