You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moreover, since the default embedding way of langchain's CSVLoader is to already embedd the field name prefixed to the field value, e.g. category: cat1\nsubcategory: subcat1\ncontent: content1 (see this test), it already achieves the same idea that the current implementation does, but in generic way.
That proposition works normally with default project chains, while giving flexibility to users that would implement their own prompt design. For example, the project default RAG Chain has this format_docs:
and users can customize this as they wish to achieve their ideas. Later, when we implement metadata saving to the vectorstore, we could even return other metadata dynamically as well.
The text was updated successfully, but these errors were encountered:
Currently, the LCEL retriever in dialog-lib forces the document content to join question and content together:
https://github.com/talkdai/dialog-lib/blob/4e8de796be1a21c877eb393066a78235e6a193ac/dialog_lib/embeddings/retrievers.py#L31-L39
However, the user already defines which fields should be embedded in
load_csv.py
`, so this retriever should keep this choice with a simple return likeMoreover, since the default embedding way of langchain's CSVLoader is to already embedd the field name prefixed to the field value, e.g.
category: cat1\nsubcategory: subcat1\ncontent: content1
(see this test), it already achieves the same idea that the current implementation does, but in generic way.That proposition works normally with default project chains, while giving flexibility to users that would implement their own prompt design. For example, the project default RAG Chain has this
format_docs
:dialog/src/dialog/llm/agents/lcel.py
Lines 60 to 61 in fbb13af
and users can customize this as they wish to achieve their ideas. Later, when we implement metadata saving to the vectorstore, we could even return other metadata dynamically as well.
The text was updated successfully, but these errors were encountered: