Add terminationGracePeriodSeconds and setup helm lint in pipeline

szymonrychu · Jun 15, 2022 · 5e6f102 · 5e6f102
1 parent b01e656
commit 5e6f102
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -51,6 +51,12 @@ jobs:
 
           curl https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
 
+      - name: Lint helm chart
+        run: |
+          set -e
+          
+          helm lint chart/${CHART_NAME}
+
       - name: Update metadata files
         run: |
           set -e

diff --git a/Dockerfile b/Dockerfile
@@ -17,7 +17,7 @@ RUN set -xe;\
         python3-pip;\
     apt-get clean;\
     rm -rf /var/lib/apt/lists/*;\
-    pip3 install ruamel.yaml requests;\
+    pip3 install ruamel.yaml requests ansible;\
     useradd -m github;\
     usermod -aG sudo github;\
     echo "%sudo ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers;\

diff --git a/chart/gha-runner/templates/deployment.yaml b/chart/gha-runner/templates/deployment.yaml
@@ -17,7 +17,7 @@ spec:
       annotations:
         {{- toYaml . | nindent 8 }}
       {{- end }}
-      labels:
+      labels: 
         {{- include "gha-runner.selectorLabels" . | nindent 8 }}
     spec:
       {{- with .Values.imagePullSecrets }}
@@ -27,6 +27,7 @@ spec:
       serviceAccountName: {{ include "gha-runner.serviceAccountName" . }}
       securityContext:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
+      terminationGracePeriodSeconds: {{ .Values.terminationGracePeriodSeconds }}
       containers:
         - name: {{ .Chart.Name }}
           securityContext:

diff --git a/chart/gha-runner/values.yaml b/chart/gha-runner/values.yaml
@@ -4,6 +4,8 @@
 
 replicaCount: 1
 
+terminationGracePeriodSeconds: 600
+
 config:
   githubPersonalToken: ""
   githubOwner: "szymonrychu"